Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inferencer): prism theme imports in ESM builds #5836

Merged
merged 3 commits into from Apr 24, 2024

Conversation

aliemir
Copy link
Member

@aliemir aliemir commented Apr 9, 2024

There's an issue with prism-react-renderer's themes when imported without an extension in ESM builds affecting @refinedev/inferencer and users with ESM environments.

Added a small plugin to our esbuild setup to replace the imports with correct file and extension.

Resolves #5834

@aliemir aliemir requested a review from a team as a code owner April 9, 2024 16:40
Copy link

changeset-bot bot commented Apr 9, 2024

🦋 Changeset detected

Latest commit: 84c61ac

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5836 April 9, 2024 16:42 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5836 April 9, 2024 16:44 Inactive
@aliemir aliemir added this to the May Release milestone Apr 9, 2024
Copy link

cypress bot commented Apr 9, 2024

Passing run #10992 ↗︎

0 53 5 0 Flakiness 0

Details:

Merge 84c61ac into ba719f6...
Project: refine Commit: 51cf2319dc ℹ️
Status: Passed Duration: 12:43 💡
Started: Apr 24, 2024 10:38 AM Ended: Apr 24, 2024 10:51 AM

Review all test suite changes for PR #5836 ↗︎

@aliemir aliemir changed the base branch from master to releases/may April 24, 2024 10:22
@aliemir aliemir merged commit cc6285d into releases/may Apr 24, 2024
26 checks passed
@aliemir aliemir deleted the fix/inferencer-theme-imports-in-esm branch April 24, 2024 10:52
@aliemir aliemir mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I updated refinedev and refinedev/inferencer and suddenly project breaks 'prism-react-renderer/themes/vsDark'
2 participants