New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(infra): migrate to lerna 8 #5821
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ccfc0e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c9f4d96. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Passing run #11059 ↗︎
Details:
Review all test suite changes for PR #5821 ↗︎ |
@@ -37,101 +37,55 @@ After you fork the Refine repository, you need to clone it to your local machine | |||
git clone https://github.com/refinedev/refine.git | |||
``` | |||
|
|||
### Installing dependencies | |||
### Installing root dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Installing root dependencies | |
### Installing dependencies |
I think we don't need to say root dependencies anymore
After bootstrapping the packages we want to work on, we need to build them in order to run properly. You can use the command below to build the packages: | ||
|
||
```sh title="Terminal" | ||
npm run build -- --scope @refinedev/antd --scope base-antd --includeDependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this build part is still relevant. We can remove things like --includeDependencies
etc. but should still keep the pnpm build
command referencer somewhere in this document. At least for the examples which won't get built with pnpm i
@@ -147,17 +101,17 @@ Refine documentation is built with [Docusaurus](https://docusaurus.io/). Documen | |||
|
|||
```sh title="Terminal" | |||
cd documentation | |||
npm install | |||
npm run dev:docs | |||
pnpm --ignore-workspace install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we've defined /documentation
as a separate workspace and don't need to use --ignore-workspace
anymore.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
Currently, we are using
lerna bootstrap
.What is the new behavior?
pnpm workspaces
gitHead
field from package.json'sfixes # (issue)
Notes for reviewers