Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra): migrate to lerna 8 #5821

Open
wants to merge 173 commits into
base: master
Choose a base branch
from
Open

Conversation

BatuhanW
Copy link
Member

@BatuhanW BatuhanW commented Apr 4, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

Currently, we are using lerna bootstrap.

What is the new behavior?

  • Migrated to pnpm workspaces
  • Updated lerna to 8
  • Updated NX config
  • Removed leftover gitHead field from package.json's
  • Disabled telemetry for e2e tests.

fixes # (issue)

Notes for reviewers

@BatuhanW BatuhanW self-assigned this Apr 4, 2024
@BatuhanW BatuhanW requested a review from a team as a code owner April 4, 2024 12:43
Copy link

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: ccfc0e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@refinedev/cli Patch
@refinedev/devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Apr 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c9f4d96. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5821 April 4, 2024 14:33 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5821 April 4, 2024 14:33 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-5821 April 4, 2024 14:50 Inactive
Copy link

cypress bot commented Apr 4, 2024

Passing run #11059 ↗︎

0 146 10 0 Flakiness 0

Details:

Merge ccfc0e0 into 39295e9...
Project: refine Commit: ed943db8a3 ℹ️
Status: Passed Duration: 18:01 💡
Started: May 9, 2024 2:57 PM Ended: May 9, 2024 3:15 PM

Review all test suite changes for PR #5821 ↗︎

@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5821 April 5, 2024 09:16 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5821 April 5, 2024 09:16 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5821 April 5, 2024 11:55 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-5821 April 5, 2024 12:16 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5821 April 5, 2024 12:49 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5821 April 5, 2024 12:49 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5821 April 5, 2024 13:40 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5821 May 9, 2024 07:24 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5821 May 9, 2024 07:25 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-5821 May 9, 2024 07:40 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5821 May 9, 2024 08:29 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5821 May 9, 2024 08:29 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5821 May 9, 2024 08:39 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5821 May 9, 2024 08:39 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-5821 May 9, 2024 08:54 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5821 May 9, 2024 11:08 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5821 May 9, 2024 11:09 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-5821 May 9, 2024 11:24 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5821 May 9, 2024 13:46 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5821 May 9, 2024 13:46 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-antd-5821 May 9, 2024 13:58 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-mui-5821 May 9, 2024 13:59 Inactive
@refine-bot refine-bot temporarily deployed to deploy-preview-website-5821 May 9, 2024 14:18 Inactive
@@ -37,101 +37,55 @@ After you fork the Refine repository, you need to clone it to your local machine
git clone https://github.com/refinedev/refine.git
```

### Installing dependencies
### Installing root dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Installing root dependencies
### Installing dependencies

I think we don't need to say root dependencies anymore

After bootstrapping the packages we want to work on, we need to build them in order to run properly. You can use the command below to build the packages:

```sh title="Terminal"
npm run build -- --scope @refinedev/antd --scope base-antd --includeDependencies
Copy link
Member

@aliemir aliemir May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this build part is still relevant. We can remove things like --includeDependencies etc. but should still keep the pnpm build command referencer somewhere in this document. At least for the examples which won't get built with pnpm i

@@ -147,17 +101,17 @@ Refine documentation is built with [Docusaurus](https://docusaurus.io/). Documen

```sh title="Terminal"
cd documentation
npm install
npm run dev:docs
pnpm --ignore-workspace install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we've defined /documentation as a separate workspace and don't need to use --ignore-workspace anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants