fix(appwrite): make meta.permissions overrideable #5767

[abdelrahman-essawy]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

• Related issue(s) linked
• Tests for the changes have been added
• Docs have been added / updated
• Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?

Users couldn't override the default readPermissions / writePermissions values.

What is the new behavior?

Users are able to override the default permissions by passing options.defaultReadPermissions / options.defaultWritePermissions OR by passing meta?.readPermissions / meta?.writePermissions.

If user passed options.defaultReadPermissions AND meta?.readPermissions, then the priority will be as following:

meta?.readPermissions if not? then options.defaultReadPermissions if not? then Role.any().

fixes #5767

Notes for reviewers

This should be compatible with old users who are not passing meta?.readPermissions and expecting to get Role.any() by default.

[changeset-bot]

🦋 Changeset detected

Latest commit: df85083

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit df85083. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• lerna run build --include-dependencies --scope @refinedev/core --scope finefoods-material-ui

---

Sent with 💌 from NxCloud.

[BatuhanW]

Hey @abdelrahman-essawy thanks for the quick PR! Added a minor comment, let's get rid of fallback any permissions completely.

[abdelrahman-essawy]

@BatuhanW I did remove the fallback value, but note that test packages/appwrite/test/create/index.spec.ts now fails.

it only passes with defaultWritePermissions, defaultReadPermissions passed in options AND not empty array.

describe("create", () => {
  it("correct response with meta", async () => {
    const { data } = await dataProvider(client, {
      databaseId: "632455a0b8d017403ce9",
      defaultWritePermissions: [Permission.write(Role.any())],
      defaultReadPermissions: [Permission.read(Role.any())]
    }).create({
      resource: "632455a55dc72e1aa016",
      variables: {
        title: "Lorem",
      },
    });
    
    expect(data.title).toEqual("Lorem");
    expect(data.id).toBeTruthy();
  });
});

[BatuhanW]

@BatuhanW I did remove the fallback value, but note that test packages/appwrite/test/create/index.spec.ts now fails.

it only passes with defaultWritePermissions, defaultReadPermissions passed in options AND not empty array.

describe("create", () => {
  it("correct response with meta", async () => {
    const { data } = await dataProvider(client, {
      databaseId: "632455a0b8d017403ce9",
      defaultWritePermissions: [Permission.write(Role.any())],
      defaultReadPermissions: [Permission.read(Role.any())]
    }).create({
      resource: "632455a55dc72e1aa016",
      variables: {
        title: "Lorem",
      },
    });
    
    expect(data.title).toEqual("Lorem");
    expect(data.id).toBeTruthy();
  });
});

Yeah, we need to update tests too. And also ideally re-record them with nock.

[BatuhanW]

Hey @abdelrahman-essawy, we've merged releases/april branch, so your PR is closed. Could you re-open your PR?

[abdelrahman-essawy]

@BatuhanW hello, I think I don't have the permission to re-open the PR nor change the base branch. note that the base branch is still refinedev:releases/april which is deleted.

[BatuhanW]

Hey @abdelrahman-essawy, I can't do it too 😨

Could you checkout a new branch from latest master and create a new PR then?

[BatuhanW]

Hey @abdelrahman-essawy we would like to release this one with May Release. Do you have time to re-open this PR so we can get it released?

[abdelrahman-essawy]

@BatuhanW sure thing, I will re-open it and update the tests this weekend.