Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): protect useLogin default success handler from custom onSuccess overrides #5889

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MohammadxAli
Copy link

@MohammadxAli MohammadxAli commented Apr 24, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes #5888

Notes for reviewers

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 8ed7ac9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MohammadxAli MohammadxAli force-pushed the fix/use-login-custom-on-success-handler-wont-override-default-on-success branch from 165b069 to 167e100 Compare April 24, 2024 22:22
@MohammadxAli MohammadxAli changed the title fix(core): ensure custom success won't override Refine's default success handler in useLogin fix(core): protect useLogin default success handler from custom onSuccess overrides Apr 24, 2024
@MohammadxAli MohammadxAli force-pushed the fix/use-login-custom-on-success-handler-wont-override-default-on-success branch from 54755f0 to 8ed7ac9 Compare April 24, 2024 22:39
@MohammadxAli MohammadxAli marked this pull request as ready for review April 24, 2024 22:39
@MohammadxAli MohammadxAli requested a review from a team as a code owner April 24, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] mutationOptions are overriding Refine's behavior unexpectedly
1 participant