fix(core): ensure passing onSuccess wouldn't override Refine behavior

refinedev · Apr 24, 2024 · 165b069 · 165b069
1 parent 9868454
commit 165b069
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/packages/core/src/hooks/auth/useLogin/index.ts b/packages/core/src/hooks/auth/useLogin/index.ts
@@ -136,15 +136,13 @@ export function useLogin<TVariables = {}>({
     return parsed.params?.to;
   }, [routerType, parsed.params, search]);
 
-  const mutation = useMutation<
-    AuthActionResponse,
-    Error | RefineError,
-    TVariables,
-    unknown
-  >({
+  const mutation = useMutation({
     mutationKey: keys().auth().action("login").get(preferLegacyKeys),
     mutationFn: loginFromContext,
-    onSuccess: async ({ success, redirectTo, error, successNotification }) => {
+    ...(v3LegacyAuthProviderCompatible === true ? {} : mutationOptions),
+    onSuccess: async (data, variables, context) => {
+      const { success, redirectTo, error, successNotification } = data;
+
       if (success) {
         close?.("login-error");
 
@@ -176,11 +174,14 @@ export function useLogin<TVariables = {}>({
       }
 
       await invalidateAuthStore();
+
+      if (!v3LegacyAuthProviderCompatible) {
+        mutationOptions?.onSuccess?.(data, variables, context);
+      }
     },
     onError: (error: any) => {
       open?.(buildNotification(error));
     },
-    ...(v3LegacyAuthProviderCompatible === true ? {} : mutationOptions),
     meta: {
       ...(v3LegacyAuthProviderCompatible === true ? {} : mutationOptions?.meta),
       ...getXRay("useLogin", preferLegacyKeys),