Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: implement getApiUrl in @refinedev/nestjs-query #5606

Open
alicanerdurmaz opened this issue Feb 7, 2024 · 5 comments
Open

[FEAT]: implement getApiUrl in @refinedev/nestjs-query #5606

alicanerdurmaz opened this issue Feb 7, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alicanerdurmaz
Copy link
Member

alicanerdurmaz commented Feb 7, 2024

Is your feature request related to a problem? Please describe.

getApiUrl method is not implemented.

Describe the thing to improve

getApiUrl method should return GraphQLClient's URL.

@alicanerdurmaz alicanerdurmaz added the enhancement New feature or request label Feb 7, 2024
@alicanerdurmaz alicanerdurmaz self-assigned this Feb 7, 2024
@alicanerdurmaz alicanerdurmaz removed their assignment Feb 29, 2024
@alicanerdurmaz alicanerdurmaz added the good first issue Good for newcomers label Feb 29, 2024
@609harsh
Copy link

609harsh commented Mar 4, 2024

Hi @alicanerdurmaz please assign this issue to me.

@Sarthakagg31
Copy link

I can fix this

@userAdityaa
Copy link

Hello, I would like to contribute in it. Is it still under action ?

@alicanerdurmaz
Copy link
Member Author

Hello @609harsh, I assigned it to you. Thanks.

@userAdityaa @Sarthakagg31 Thanks, I assigned to @609harsh because @609harsh wrote before. if @609harsh is not available, we will communicate again

yess-wee added a commit to yess-wee/refine that referenced this issue Apr 12, 2024
changed ,
// getApiUrl: () => {
    //   throw Error("Not implemented on refine-nestjs-query data provider.");
    // },

to

getApiUrl: () => {
    return client.getApiUrl();
},
@omeraplak omeraplak added this to the May Release milestone Apr 17, 2024
@aliemir aliemir removed this from the May Release milestone May 2, 2024
@aliemir
Copy link
Member

aliemir commented May 2, 2024

Due to inactivity in PR #5844, we're looking for new contributors to implement this feature 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants