New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap reaction avatars to avoid "CSS IS AWESØME" #2904

Merged

fregante merged 3 commits into master from wrap-reaction-avatars

Mar 22, 2020

Member

fregante commented Mar 20, 2020 •

edited by issuehunt-oss bot

Fixes #1744

Issues are now responsive, we can't use previous JS solutions that only run on load
CSS Grid doesn't allow automatic wrap
CSS flex-grow can't be used because if there's a 1-avatar reaction on the second line, it will be stretched along the whole line, making it huge

Demos from facebook/react#13525

Some aren't great, but that's just how it is 🤷‍♂️

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

#1744: Reactions container stretches beyond width of comment area

IssueHunt has been backed by the following sponsors. Become a sponsor

fregante added 3 commits

March 20, 2020 11:18


          Allow wrapping of reactions

2dd10bb


          Fix border when the second line is longer than the first one

03cacef


          Slightly increase overlap to allow for more avatars

6fc73bd

fregante added the bug label

fregante merged commit 236d643 into master

fregante deleted the wrap-reaction-avatars branch

March 22, 2020 21:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment