Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fully remove Edgio Deploy from CLI and Docs #10358

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thedavidprice
Copy link
Contributor

This is currently being discussed and is open to everyone via comments here. If we do decide to move forward with this PR it will happen along with the next major version of Redwood and no sooner.

Why?

The Edgio deployment is not being used by Redwood devs per looking at metrics from the previous 3 months — there are 0 recorded instances of yarn rw setup deploy edgio being run.

First-class, built-in support of deployment providers requires quite a bit of overhead in terms of ongoing maintenance and CI/CD.

  • setup commands need to be updated; in this case, I'm not even sure the current setup command uses the correct Edgio packages
  • we have CI/CD and monitoring for all deployment providers; Edgio CI deploy project requires ongoing management and maintenance and must be verified with every release

Discussion Topics

  1. When is it appropriate to remove 3rd party integrations and services? And, if we determine it's time to remove them, how should we structure the process?
  2. What alternatives are there to entirely removing these types of integrations; e.g. moving the package to a plug-in, finding a community lead, etc.?
  3. What do we do next regarding Edgio deploy and this PR (if not fully remove in the next major)?

To Do

Verification

  • sanity check usage via telemetry metrics
  • discuss with Edgio team

Moving Forward

  • determine appropriate process and communication
  • remove from CI/CD

@thedavidprice thedavidprice marked this pull request as draft March 28, 2024 16:35
@Tobbe
Copy link
Member

Tobbe commented Apr 3, 2024

FWIW I support removing it.

We could do what we did for the auth providers we got rid of, and that's to just move the code to a separate repo, like https://github.com/redwoodjs/auth-nhost and link to that in the release notes if anyone wants to pick up on the work.

I haven't thought about/looked into what it would mean to support deployment providers as plugins though (like we do for auth)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants