Fix webpack 4 support by setting target: es2017 for redux.legacy-esm.js
#370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Thanks! |
aryaemami59
added a commit
to aryaemami59/redux-thunk
that referenced
this pull request
Mar 22, 2024
Add `.gitattributes` file to make line endings more consistent (reduxjs#363) Fix webpack 4 support by setting `target: es2017` for `redux.legacy-esm.js` (reduxjs#370) Revert "Run Prettier on all files" This reverts commit 39e8094. Run Prettier on all files
aryaemami59
added a commit
to aryaemami59/redux-thunk
that referenced
this pull request
Mar 22, 2024
Add `.gitattributes` file to make line endings more consistent (reduxjs#363) Fix webpack 4 support by setting `target: es2017` for `redux.legacy-esm.js` (reduxjs#370) Revert "Run Prettier on all files" This reverts commit 39e8094. Run Prettier on all files Add `.gitattributes` file to make line endings more consistent (reduxjs#363)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Even though this change does not make a difference in output, it would still be good to correct this now just so it doesn't become an issue later on.
This PR:
target: es2017forredux.legacy-esm.jswhich is related toredux-toolkit.legacy-esm.jsnot actually compatible with Webpack 4 due to optional chaining redux-toolkit#4282 and Fix webpack 4 support by settingtarget: es2017forredux.legacy-esm.jsredux#4687.