New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 development #54
V1 development #54
Conversation
…e code in MetadataProvider that seems to be simpler with _.each
…inimal modification over UIManager
Now this is a big refactor. Thank you @danigomez . |
@andrerpena I have removed the demo from v1-development too. That's why this is a big refactor. It was my fault, I pushed to v1-development and then I forget that I should delete the demo from master. Bad mine 😕 |
@andrerpena Yes!, all the karma test passed using Chrome, but are failing with PhantomJS for some reason.... i also tested in the demo an all is still working! |
@andrerpena I wil merge it now! @danigomez tested locally that this is working and still works really good. Then you can review it! 😄 |
Ok thank you both |
This completes the issue #46 !
We should review why PhantomJS is failing to run the test (ariya/phantomjs#14096), the test are running correctly when using the Chrome browser.