Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 development #54

Merged
merged 10 commits into from Jul 26, 2016
Merged

V1 development #54

merged 10 commits into from Jul 26, 2016

Conversation

danigomez
Copy link
Contributor

This completes the issue #46 !
We should review why PhantomJS is failing to run the test (ariya/phantomjs#14096), the test are running correctly when using the Chrome browser.

@andrerpena
Copy link
Member

Now this is a big refactor. Thank you @danigomez .
Of course you ran all tests and also did exploratory manual tests on the demo, right? I just wanted to confirm. If that's the case I'll just merge it and review it afterwards.

@andrerpena
Copy link
Member

Does that mean you added 50 lines and removed 1756????

image

@JonatanSalas
Copy link
Member

JonatanSalas commented Jul 26, 2016

@andrerpena I have removed the demo from v1-development too. That's why this is a big refactor. It was my fault, I pushed to v1-development and then I forget that I should delete the demo from master. Bad mine 😕

@danigomez
Copy link
Contributor Author

danigomez commented Jul 26, 2016

@andrerpena Yes!, all the karma test passed using Chrome, but are failing with PhantomJS for some reason.... i also tested in the demo an all is still working!

@JonatanSalas
Copy link
Member

@andrerpena I wil merge it now! @danigomez tested locally that this is working and still works really good. Then you can review it! 😄

@JonatanSalas JonatanSalas merged commit dfacb0a into master Jul 26, 2016
@andrerpena
Copy link
Member

Ok thank you both

@JonatanSalas JonatanSalas deleted the v1-development branch August 2, 2016 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants