Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Skip validation for symbols for inline code block #819

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] Skip validation for symbols for inline code block #819

wants to merge 3 commits into from

Conversation

takahi-i
Copy link
Member

@takahi-i takahi-i commented Dec 17, 2017 •
edited

Ref #817

@takahi-i takahi-i changed the title Skip validation for symbols for inline code block [WIP] Skip validation for symbols for inline code block Dec 17, 2017
@takahi-i
Copy link
Member Author

takahi-i commented Dec 17, 2017 •
edited

Looks need to Line#erase returns ranges of erased positions

@coveralls
Copy link

coveralls commented Dec 17, 2017 •
edited

Coverage Status

Coverage decreased (-0.06%) to 91.281% when pulling 0b789f2 on takahi-i:handle-inline-code into a8f05ae on redpen-cc:master.

@takahi-i
Copy link
Member Author

As the first step I will refactor and add tests Line, LineParser, and Model classes.

@takahi-i
Copy link
Member Author

TODO: refactoring Line#eraseEnclosure

@makenowjust makenowjust mentioned this pull request Mar 17, 2018
Open
@makenowjust
Copy link

@takahi-i What is the status on this?

@takahi-i
Copy link
Member Author

takahi-i commented Sep 9, 2018

@makenowjust to be honest it is slow progress... I will tackle this problem in the next vacation.

@makenowjust
Copy link

@takahi-i Thank you for your response. I'm waiting patiently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@takahi-i @coveralls @makenowjust