util/conversion: support IEC prefix like "Ki" #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use string_view instead of string, as string_view would suffice for conversion and for building a vector<char> Signed-off-by: Kefu Chai <tchaikov@gmail.com> Message-Id: <20220614134429.3750381-1-tchaikov@gmail.com>
would be ideal if we can use IEC prefix when specifying the memory usage. so we can just pass the settings used elsewhere, like Kubernetes, to a Seastar application. Signed-off-by: Kefu Chai <tchaikov@gmail.com> Message-Id: <20220614135859.3913356-1-tchaikov@gmail.com>
|
ping? |
|
yet another ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the first prerequisite of a better fix of redpanda-data/redpanda#352 -- to teach Seastar to understand IEC prefixes. and then, we can probably revert redpanda-data/redpanda#602 if rpk always has a strong dependency on the same version of the redpanda daemon executable.
the change has been merged in upstream. see scylladb@23a57b8