net/probes: Expect vector<byte> from cert_info #18287
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphcareful
previously approved these changes
May 7, 2024
oleiman
force-pushed
the
tls-metrics/cert-info-byte-vec
branch
from
760f0b4
to
7431a0d
Compare
|
force push rebase dev to fix vtools PR build |
pgellert
previously approved these changes
May 10, 2024
7 tasks
oleiman
force-pushed
the
tls-metrics/cert-info-byte-vec
branch
from
7431a0d
to
8aab61f
Compare
oleiman
force-pushed
the
tls-metrics/cert-info-byte-vec
branch
from
8aab61f
to
bb6ad7d
Compare
char_traits<unsigned T> is deprecated in LLVM 18, slated for removal in LLVM 19. Having replaced the only instance of basic_sstring<unsigned> in seastar with a vector<byte>, we need to account for that change here. Requires redpanda-data/seastar: d96474c6a96919b4f260dbd5ba22827948c4e000 Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
oleiman
force-pushed
the
tls-metrics/cert-info-byte-vec
branch
from
bb6ad7d
to
ba62518
Compare
pgellert
approved these changes
May 14, 2024
|
Thanks for the informative commit message! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
char_traits<unsigned T>is deprecated in LLVM 18, slated for removal in LLVM 19. Having replaced the only instance ofbasic_sstring<unsigned>in seastar with avector<byte>, we need to account for that change here.Requires redpanda-data/seastar: d96474c6a96919b4f260dbd5ba22827948c4e000
Backports Required
Release Notes