This repository has been archived by the owner on Jan 14, 2020. It is now read-only.
Use 12:00 as a reference point for simple dates instead of midnight. (#4025) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(#4025) In locales where DST timezone changes occur on midnight (like Brazil) the calendar becomes confused which date to show. On DST ends, the date sprung back from 2010-10-17 00:00 to 2010-10-16 23:00 in Brazil. Thus, the date 2010-10-16 was shown two times. Using 12 as the default hour for dates does circumvent this issue. If DST changes occur around noon or the time picker functionality is used, this still breaks however.
samchen2009
added a commit
to samchen2009/redmine
that referenced
this pull request
Dec 28, 2012
samchen2009
added a commit
to samchen2009/redmine
that referenced
this pull request
Dec 30, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In locales where DST timezone changes occur on midnight (like Brazil) the calendar becomes confused which date to show. On DST ends, the date sprung back from 2010-10-17 00:00 to 2010-10-16 23:00 in Brazil. Thus, the date 2010-10-16 was shown two times. Using 12 as the default hour for dates does circumvent this issue. If DST changes occur around noon or the time picker functionality is used, this still breaks however.