Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes in tuned-ppd #629

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

zacikpa
Copy link
Contributor

@zacikpa zacikpa commented Apr 19, 2024

Having used tuned-ppd by default for a couple of months, I've discovered a couple of bugs that should be resolved by this PR.

Do not iterate directly through the dictionary of holds,
because it's being modified. Instead, iterate through
the list of the dictionary keys.
In rare cases, 'lap-mode' and 'no-turbo' files may be
empty. Do not attempt to convert their content into
integers. Instead check if it's directly equal to "1"
(after stripping whitespace).
@zacikpa zacikpa assigned yarda and unassigned yarda Apr 19, 2024
@zacikpa zacikpa requested a review from yarda April 19, 2024 08:04
Copy link
Contributor

@yarda yarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@yarda yarda merged commit c523813 into redhat-performance:master May 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants