Re-check dbus when (re)starting TuneD from tuned-adm profile #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If TuneD was simply off before the restart, we can then switch the profile using the dbus method. Otherwise we fallback to a profile switch via setting the active_profile file (where we do not check for success).
|
Thanks, LGTM, but the changed output messages will require update of the Beaker tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TuneD is off, and a profile is applied using
tuned-adm profile, the command attempts to start it. Before this change, the profile would always be applied via theactive_profilefile.When TuneD supports DBus, we can change the profile via a DBus call instead, and thus get information about the result. After the restart, I therefore added a new check which determines whether TuneD is on the dbus. If it's not, we fallback to the original profile activation.
The only disadvantage of this approach is that TuneD is restarted twice in the unlikely scenario that both
enable_dbusanddaemonare turned on, but TuneD does not become active on the DBus after a restart. This would, however, signalize some misconfiguration because if the TuneD service unit hastype=dbusset, restarting the service hangs until it becomes active on the DBus.Resolves #623.