plugin_cpu: decrease the severity of _has_pm_qos==False #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature depends on kernel configuration (CONFIG_CPU_IDLE). While this seems to be commonly enabled on x86, we've seen ARM systems where it's disabled, and in this case it's perfectly valid for /dev/cpu_dma_latency to be missing. Since we cannot opt-out of the PM QoS feature in the cpu plugin, this case should not be an error. Signed-off-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
|
LGTM, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature depends on kernel configuration (CONFIG_CPU_IDLE). While this seems to be commonly enabled on x86, we've seen ARM systems where it's disabled, and in this case it's perfectly valid for /dev/cpu_dma_latency to be missing.
Since we cannot opt-out of the PM QoS feature in the cpu plugin, this case should not be an error.