Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/beakerlib: Add new test which covers build-in functions. #591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RHEmployee
Copy link
Contributor

No description provided.

@@ -0,0 +1,16 @@
import base
from tuned.utils.commands import commands

Check notice

Code scanning / CodeQL

Unused import

Import of 'commands' is not used.
@@ -0,0 +1,16 @@
from . import base
from tuned.utils.commands import commands

Check notice

Code scanning / CodeQL

Unused import

Import of 'commands' is not used.
super(self.__class__, self).__init__("testfunc", 2)

def execute(self, args):
f = open(str(args[0]),'w')

Check warning

Code scanning / CodeQL

File is not always closed

File may not be closed if an exception is raised.
super(self.__class__, self).__init__("testfunc", 2)

def execute(self, args):
f = open(str(args[0]),'w')

Check warning

Code scanning / CodeQL

File is not always closed

File may not be closed if an exception is raised.
@yarda
Copy link
Contributor

yarda commented Feb 8, 2024

@RHEmployee could you fix the CodeQL found issues and could you fix the test?

@RHEmployee
Copy link
Contributor Author

Rhel7 or centos7 is not supported by this test which is reflected in provided metadata.

One issue is preset: wrong detection of centos.

@yarda
Copy link
Contributor

yarda commented May 21, 2024

/test

@yarda
Copy link
Contributor

yarda commented May 21, 2024

/packit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants