added a new test prepare env for host test case #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhutar
reviewed
Aug 9, 2021
| - name: lock | ||
| command: "{{item}}" | ||
| with_items: | ||
| - echo "ProvisioningTemplate.update_all(locked: false)" | foreman-rake console |
There was a problem hiding this comment.
I'm pretty sure this will not work as pipe | is a shell construct that does not work with command task
jhutar
reviewed
Aug 9, 2021
|
|
||
| - name: lock | ||
| command: "{{item}}" | ||
| with_items: |
There was a problem hiding this comment.
Why not 3 separate tasks? IMO it just makes the script harder to read
jhutar
reviewed
Aug 9, 2021
| with_items: | ||
| - echo "ProvisioningTemplate.update_all(locked: false)" | foreman-rake console | ||
| - hammer template build-pxe-default | ||
| - PROV_TEMPLATES="Kickstart default,Kickstart default finish,Kickstart default PXELinux,Kickstart default user data" |
There was a problem hiding this comment.
Setting a bash variable in one task and using it in another does not work as these are two different environments
jhutar
reviewed
Aug 9, 2021
|
|
||
| - name: hammer architecture create | ||
| command: | ||
| hammer -u "{{ sat_user}}" -p "{{ sat_pass }}" os create --name "RHEL" --major 8 --minor 4 --description="RHEL 8.4" --media "RHEL mirror" --provisioning-templates "$PROV_TEMPLATES" --architectures "x86_64" --family Redhat --partition-tables "Kickstart default" |
There was a problem hiding this comment.
Looks like we use that variable only on one place, so we do not need to define it at all
jhutar
reviewed
Aug 9, 2021
| command: | ||
| hammer -u "{{ sat_user}}" -p "{{ sat_pass }}" compute-resource create --provider "libvirt" --name "MyLibvirtComputeResource" --set-console-password "false" --url "qemu+ssh://root@192.168.111.1/system" --organizations "MyOrg" --locations "MyLoc" | ||
|
|
||
| # For testing we don't need to have them locked |
There was a problem hiding this comment.
What do you mean by locking here?
pablomh
force-pushed
the
main
branch
5 times, most recently
from
71883ab
to
2db3161
Compare
pablomh
force-pushed
the
main
branch
3 times, most recently
from
0b4e005
to
1427f03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.