Refactor binaries download and fix few linting issues and typo #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbutenhof
reviewed
May 7, 2024
dbutenhof
reviewed
May 8, 2024
akrzos
reviewed
May 8, 2024
rabin-io
force-pushed
the
fix-1
branch
3 times, most recently
from
b96008b
to
290bedf
Compare
rabin-io
changed the title
dbutenhof
reviewed
May 10, 2024
rabin-io
force-pushed
the
fix-1
branch
2 times, most recently
from
eb739f3
to
48ef960
Compare
dbutenhof
approved these changes
May 13, 2024
|
Any update? |
akrzos
requested changes
May 28, 2024
There was a problem hiding this comment.
Hi Rabin, I attempted to run the setup-bastion in my environment and immediate ran into this issue:
TASK [bastion-install : Get rhel8 opm] *******************************************************************************************************************************************************
Tuesday 28 May 2024 13:51:47 -0400 (0:00:16.220) 0:00:44.929 ***********
fatal: [e38-h01-000-r650.rdu2.scalelab.redhat.com]: FAILED! => {"msg": "'openshift_client_url' is undefined. 'openshift_client_url' is undefined"}This can speed up execution if we have the files on the node
Signed-off-by: Rabin Yasharzadehe <rabin@rabin.io>
akrzos
requested changes
May 29, 2024
| mode: "0700" | ||
| - url: "{{ yq_url }}" | ||
| dest: "{{ bastion_cluster_config_dir }}/yq_linux_amd64.tar.gz" | ||
| force: false |
There was a problem hiding this comment.
Why was this changed? I believe believe force was set to guarantee it pulls the item down.
There was a problem hiding this comment.
Yes correct, but you can optimize it when using the checksum, if the file in the destination have the same checksum, you won't need to download the file again.
| @@ -9,14 +9,14 @@ address=/{{ groups['bastion'][0] }}/{{ bastion_controlplane_ip }} | |||
| address=/api.{{ cluster_name }}.{{ base_dns_name }}/{{ controlplane_network_api }} | |||
| address=/apps.{{ cluster_name }}.{{ base_dns_name }}/{{ controlplane_network_ingress }} | |||
|
|
|||
| {% if groups['hv_vm'] is defined and (groups['hv_vm'] | length > 0) %} | |||
There was a problem hiding this comment.
I'm not sure I am in a current position to test the changes to the jinja statements here just yet. I'm trying to recall if there will be any un-intended side affects by adjusting what gates what here, so it might take me a few days to test this.
+ Refactor the task which downloads the helper files to use checksum to verify the downloads + ansible-lint auto fix - Truthy value should be one of [false, true] - File permissions unset or incorrect - Use FQCN for builtin module actions Signed-off-by: Rabin Yasharzadehe <rabin@rabin.io>
akrzos
reviewed
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.