Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure SNO deployment #813

Merged
merged 1 commit into from
May 21, 2024
Merged

Azure SNO deployment #813

merged 1 commit into from
May 21, 2024

Conversation

ebattat
Copy link
Collaborator

@ebattat ebattat commented May 9, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

  1. Add dedicated CI workflows to run for each pull request using the Azure cluster.
  2. Add a method to start the cluster with a verification mechanism to ensure that the cluster is up and running, including a retry mechanism.
  3. Disable all ODF integration tests.
  4. Reduce memory and CPU consumption in the UPerf/Stressng workflow.
  5. Enable Azure tests and skip start/stop tests during testing because it's our test cluster.
  6. Enable the Stressng workflow in integration tests; it's faster and lighter than UPerf.
  7. Regenerate all test workflow templates.

For security reasons, all pull requests need to be approved first before running any automated CI

@ebattat ebattat added the enhancement New feature or request label May 9, 2024
@ebattat ebattat requested a review from RobertKrawitz May 9, 2024 07:45
@ebattat ebattat self-assigned this May 9, 2024
@ebattat ebattat added this to In progress in benchmark-runner via automation May 9, 2024
RobertKrawitz
RobertKrawitz requested changes May 9, 2024
View reviewed changes
Copy link
Member

@RobertKrawitz RobertKrawitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things, mostly quote-related.

.github/workflows/Perf_Env_Build_Azure_Test_CI.yml Show resolved Hide resolved
.github/workflows/Perf_Env_Build_Azure_Test_CI.yml Outdated Show resolved Hide resolved
.github/workflows/Perf_Env_Build_Azure_Test_CI.yml Show resolved Hide resolved
.github/workflows/Perf_Env_Build_Azure_Test_CI.yml Outdated Show resolved Hide resolved
.github/workflows/Perf_Env_Build_Azure_Test_CI.yml Outdated Show resolved Hide resolved
benchmark_runner/common/clouds/Azure/azure_operations.py Outdated Show resolved Hide resolved
benchmark_runner/common/clouds/Azure/azure_operations.py Show resolved Hide resolved
benchmark_runner/main/main.py Outdated Show resolved Hide resolved
benchmark_runner/main/main.py Outdated Show resolved Hide resolved
tests/integration/benchmark_runner/benchmark_operator/test_oc_benchmark_operator.py Outdated Show resolved Hide resolved
@ebattat ebattat force-pushed the azure_sno_test_cluster branch 4 times, most recently from 1ae8aeb to f81b4f5 Compare May 15, 2024 07:25
@ebattat
Copy link
Collaborator Author

ebattat commented May 15, 2024

@RobertKrawitz, do you have more comments ?

@ebattat ebattat changed the title Azure SNO test cluster support Azure SNO deployment May 20, 2024
@ebattat
Copy link
Collaborator Author

ebattat commented May 20, 2024

@RobertKrawitz, Do you have any comment here ?

RobertKrawitz
RobertKrawitz requested changes May 20, 2024
View reviewed changes
benchmark_runner/main/main.py Outdated Show resolved Hide resolved
benchmark_runner/main/main.py Outdated Show resolved Hide resolved
RobertKrawitz
RobertKrawitz requested changes May 20, 2024
View reviewed changes
benchmark_runner/main/main.py Outdated Show resolved Hide resolved
@ebattat
Copy link
Collaborator Author

ebattat commented May 20, 2024

@RobertKrawitz rewrite azure_cluster_operations using enum, ptal

@RobertKrawitz
Copy link
Member

@RobertKrawitz rewrite azure_cluster_operations using enum, ptal

lgtm, approved.

@ebattat ebattat merged commit b001e86 into redhat-performance:main May 21, 2024
4 checks passed
benchmark-runner automation moved this from In progress to Done May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertKrawitz RobertKrawitz RobertKrawitz approved these changes

Assignees

@ebattat ebattat

Labels
enhancement New feature or request
Projects
benchmark-runner
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ebattat @RobertKrawitz