Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check for customTags #955

Merged

Conversation

datho7561
Copy link
Contributor

What does this PR do?

Add null check for customTags setting, so if the setting is not set completion will not fail.

What issues does this PR fix or reference?

Fixes #807

Is it tested? How?

I added an integration test.

Fixes redhat-developer#807

Signed-off-by: David Thompson <davthomp@redhat.com>
@coveralls
Copy link

coveralls commented Mar 21, 2024

Coverage Status

coverage: 84.174% (+0.04%) from 84.138%
when pulling d97f95e on datho7561:807-custom-tags-null-check
into 0e17579 on redhat-developer:main.

Copy link
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msivasubramaniaan msivasubramaniaan merged commit 0871dc1 into redhat-developer:main May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Studio Client Integration: Server throws cannot read properties of undefined (reading 'length')
4 participants