Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Fix syntax highlighting #945

Conversation

pierreprinetti
Copy link
Contributor

All JSON is YAML, but no the other way around.

What does this PR do?

Fix syntax highlighting in the README.

What issues does this PR fix or reference?

Closes #944

Is it tested? How?

See the rendering: here.

All JSON is YAML, but no the other way around.
@pierreprinetti
Copy link
Contributor Author

See also: #938 which may be a better solution than this one.

@coveralls
Copy link

coveralls commented Dec 19, 2023

Coverage Status

coverage: 84.071%. remained the same
when pulling 03d3f47 on pierreprinetti:readme_set_yaml_on_examples
into d354c58 on redhat-developer:main.

Copy link
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msivasubramaniaan msivasubramaniaan merged commit 5458ed3 into redhat-developer:main Jan 5, 2024
4 checks passed
@pierreprinetti pierreprinetti deleted the readme_set_yaml_on_examples branch January 5, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: The examples in the README have their syntax set wrong
3 participants