Feat: add title source hover settings #892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q-rault
changed the title
|
@msivasubramaniaan Are you able to take a look at this? or @gorkem Do you know who owns this after you've left red hat? |
|
@q-rault please resolve conflicts. @jpinkney-aws I'll review it by next week |
q-rault
force-pushed
the
feat/add-title-source-hover-settings
branch
from
7a66521
to
6344c54
Compare
|
@msivasubramaniaan I wanted to kindly request your review on the changes made in this pull request when you have a chance. We are also interested in this feature |
🤷 probably under staffed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds hover settings to enable/disable Title and Source from hover tooltip
What issues does this PR fix or reference?
It is based on the work of @nikalexxx from 2022/05, see here for context and pictures of what the PR does
Original didn't pass the CI because of format/lint issues.
It is now correctly linted
Is it tested? How?
Two unitary tests were added, correctly showing the result when the new settings are enabled/disabled