Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable telemetry in Web extension #903

Merged

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Mar 15, 2023

Signed-off-by: Fred Bricon fbricon@gmail.com

What does this PR do?

Enables Telemetry when the extension runs in a Web browser

What issues does this PR fix or reference?

No linked issue

Is it tested? How?

Best way to test this is to run a CLI build:

yarn build

Then launch an http server and create a tunnel to expose it online. In one terminal run:

npx serve --cors -l 5000

This will start a web server on port 5000. Then, in a second terminal, execute:

npx localtunnel -p 5000

This will expose your local web server to a public URL like https://<fancy-name>-<your-IP>.loca.lt
Copy that URL, open it in a browser, click on the button to enable it.

Then go to https://vscode.dev, if you already have redhat.vscode-yaml installed, uninstall it.
With the command palette (Ctrl+Shift+P/Cmd+Shift+P on mac), run the Developer: Install Extension from Location... command.
Paste your loca.lt URL

Create a new document, select YAML language, you should see the Red Hat telemetry Opt-in popup. After accepting it and you should see a startup event in Amplitude

Signed-off-by: Fred Bricon <fbricon@gmail.com>
Copy link
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested on my local and able to see the event in amplitude

@msivasubramaniaan msivasubramaniaan merged commit 0d3a44c into redhat-developer:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants