feat: add basic devfile and vscode settings to the repo #459
Conversation
mkuznyetsov
force-pushed
the
devtools-impr
branch
from
63ae5a0
to
9631f5f
Compare
mkuznyetsov
requested review from
nickboldt,
svor,
l0rd and
ibuziuk
as code owners
mkuznyetsov
changed the title
mkuznyetsov
changed the title
devfile.yaml
Outdated
| components: | ||
| - name: tools | ||
| container: | ||
| image: quay.io/devspaces/devspaces-images-dev:latest |
There was a problem hiding this comment.
When trying your PR on workspaces.openshift.com I get "Failed to pull image "quay.io/devspaces/devspaces-images-dev:latest": rpc error: code = Unknown desc = reading manifest latest in quay.io/devspaces/devspaces-images-dev: unauthorized: access to the requested resource is not authorized". Maybe the image is private or not pushed yet?
devfile.yaml
Outdated
| schemaVersion: 2.2.0 | ||
| metadata: | ||
| name: devspaces-images | ||
| # add components:, unless basic udi component is good enough? |
There was a problem hiding this comment.
| # add components:, unless basic udi component is good enough? |
I think you can remove this no? If you have added the Dockerfile it's because you want go v1.18 (and currently basic udi has 1.19) right?
There was a problem hiding this comment.
it needs to be 1.19, similarly to how it is defined in upstream. it's probably better to hardcode it this way, as udi's golang version can go further (it is at 1.20 right now)
| { | ||
| "recommendations": [ | ||
| "rogalmic.bash-debug", | ||
| "redhat.vscode-yaml" |
|
|
||
| #install Go 1.18 (needed to work with devspaces-operator) | ||
| RUN cd /tmp && wget https://go.dev/dl/go1.18.6.linux-amd64.tar.gz && \ | ||
| mkdir $HOME/go1.18 && \ |
There was a problem hiding this comment.
can we update this to go 1.20 since that's what we're using downstream?
devfile.yaml
Outdated
| @@ -0,0 +1,43 @@ | |||
| # | |||
| # Copyright (c) 2019-2021 Red Hat, Inc. | |||
| context: . | ||
| file: .devfile.Dockerfile | ||
| push: true | ||
| tags: quay.io/devspaces/devspaces-images-dev:latest |
There was a problem hiding this comment.
Should this be :next if it's CI?
| components: | ||
| - name: tools | ||
| container: | ||
| image: quay.io/devfile/universal-developer-image:ubi8-latest |
There was a problem hiding this comment.
why are you using the upstream UDI image in a devfile for the downstream UDI image?
| # Red Hat, Inc. - initial API and implementation | ||
|
|
||
| # This container featres tools required for Devspaces Images | ||
| FROM quay.io/devfile/universal-developer-image:ubi8-latest |
There was a problem hiding this comment.
if this is something you want to see built downstream, you aren't allowed to use FROM quay.io in OSBS.
There was a problem hiding this comment.
this image is not needed to be built downstream. It's only used as a tooling container, when this workspace will be used in Che/Devspaces
|
Can you link to the relevant GH action and/or JIRA that explains why we are adding these files? Please provide better pull request description -- "It will be extended as more usage will occure" is not very clear. |
Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
mkuznyetsov
force-pushed
the
devtools-impr
branch
from
11f0a8a
to
3a1cd3b
Compare
Signed-off-by: Mykhailo Kuznietsov mkuznets@redhat.com
Add basic Devfile structure and vscode extension settings
It will be extended as more usage will occur
related issue: One of the previous DevTools Week Dogfooding sessions, where we were encouraged to create/update Devfiles for development