Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest node lts? #654

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kabir
Copy link

@kabir kabir commented Mar 23, 2023

I don't know if this is desirable or not :-)

However, I am getting a lot of problems trying to run this with the indicated node version. A lot of the time nvm does not downgrade the npm version on my system (9.2.0) to the one I've been told the 16.6.2 should use or not.

It seems that npm 9.2.0 is stricter about the dependencies, resulting in errors running npm install like:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: optimize-css-assets-webpack-plugin@6.0.1
npm ERR! Found: webpack@5.51.1
npm ERR! node_modules/webpack
npm ERR!   dev webpack@"5.51.1" from the root project
npm ERR!   peer webpack@">=5.0.0" from assets-webpack-plugin@7.1.1
npm ERR!   node_modules/assets-webpack-plugin
npm ERR!     dev assets-webpack-plugin@"7.1.1" from the root project
npm ERR!   17 more (copy-webpack-plugin, css-loader, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^4.0.0" from optimize-css-assets-webpack-plugin@6.0.1
npm ERR! node_modules/optimize-css-assets-webpack-plugin
npm ERR!   dev optimize-css-assets-webpack-plugin@"6.0.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: webpack@4.46.0
npm ERR! node_modules/webpack
npm ERR!   peer webpack@"^4.0.0" from optimize-css-assets-webpack-plugin@6.0.1
npm ERR!   node_modules/optimize-css-assets-webpack-plugin
npm ERR!     dev optimize-css-assets-webpack-plugin@"6.0.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/kabir/.npm/_logs/2023-03-23T15_37_31_787Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/kabir/.npm/_logs/2023-03-23T15_37_31_787Z-debug-0.log

If the upgrade to node 18.15 is not wanted, I think it would make it more user friendly if the second commit removing the incompatible dependency was merged. I've tried npm run build and npm run start:dev on my side to verify, although I am not very familiar with the project :-)

… as outlined in the README.

The recommended css-minimizer-webpack-plugin is used instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant