Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1Password Connect and Operator #287

Merged
merged 2 commits into from
May 22, 2024

Conversation

rarguello
Copy link
Contributor

Adds support for the 1Password Connect and Operator: https://developer.1password.com/docs/connect/

@strangiato
Copy link
Contributor

Hey @rarguello, thank you for your contribution.

I see that the onepassword as a helm chart for the operator that it would expect to be installed. It would be great to have references for installing those pre-reqs as part of the PR. I like where you are going with showing how to generate the secrets that a user is expected to provide, but I think there is still some missing context for what needs to be deployed before this resource can be utilized.

We don't have any examples of using kustomize's helmChart feature in the repo but that may be a good fit to allow it to follow some of the same patterns we follow in the rest of the repo.

I also went ahead and triggered the github actions to run. It does look like the spellcheck caught a few issues. Some of those are probably false positives for some technical words that just haven't been added to the .wordlist-md. If you need any assistance with updating that wordlist please let me know.

@rarguello
Copy link
Contributor Author

Sorry, pushed the whole thing this time.
The Helm chart is missing the SCC required for this to work on OpenShift.

@strangiato strangiato merged commit 81df102 into redhat-cop:main May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants