-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to run the e2e-tests from rhtap-build-tenant ns #3703
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you improve the description to explain why exactly this is needed?
If I understand correctly, it's because we onboarded the https://github.com/redhat-appstudio/build-tasks-dockerfiles/ repo to konflux, so now all the pipelines in that repo have to run in the rhtap-build-tenant namespace. And we want to run e2e tests in that repo as a Tekton pipeline, not via Prow (why?).
We wanted to use a konflux integration test for running the e2e-tests after source-build image is built, use similar approach like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Ack, thanks for the explanation 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmeliik, tisutisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aec5505
into
redhat-appstudio:main
rhtap-build-tenant:appstudio-pipeline
SA needs the same level of privileges that ourtekton-ci:appstudio-pipeline
sa has, to be able to run the e2e-tests inbuild-templates-e2e
namespace of production cluster.This PR adds required role-binding for
rhtap-build-tenant:appstudio-pipeline
SA to run e2e-tests in build-templates-e2e ns.Part of the story: https://issues.redhat.com/browse/STONEBLD-2353
After the source-build image is built, we will run the e2e-tests through the integration-pipeline added in this PR