Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to run the e2e-tests from rhtap-build-tenant ns #3703

Merged
merged 1 commit into from
May 21, 2024

Conversation

tisutisu
Copy link
Member

@tisutisu tisutisu commented May 15, 2024

rhtap-build-tenant:appstudio-pipeline SA needs the same level of privileges that our tekton-ci:appstudio-pipeline sa has, to be able to run the e2e-tests in build-templates-e2e namespace of production cluster.
This PR adds required role-binding for rhtap-build-tenant:appstudio-pipeline SA to run e2e-tests in build-templates-e2e ns.
Part of the story: https://issues.redhat.com/browse/STONEBLD-2353
After the source-build image is built, we will run the e2e-tests through the integration-pipeline added in this PR

Copy link

openshift-ci bot commented May 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tisutisu tisutisu changed the title feat: Add ability to run the e2e-tests in build-templates-e2e ns feat: Add ability to run the e2e-tests from rhtap-build-tenant ns May 15, 2024
@tisutisu tisutisu marked this pull request as ready for review May 15, 2024 07:11
@openshift-ci openshift-ci bot requested review from jgwest and scoheb May 15, 2024 07:11
Copy link
Member

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you improve the description to explain why exactly this is needed?

If I understand correctly, it's because we onboarded the https://github.com/redhat-appstudio/build-tasks-dockerfiles/ repo to konflux, so now all the pipelines in that repo have to run in the rhtap-build-tenant namespace. And we want to run e2e tests in that repo as a Tekton pipeline, not via Prow (why?).

@tisutisu
Copy link
Member Author

Could you improve the description to explain why exactly this is needed?

If I understand correctly, it's because we onboarded the https://github.com/redhat-appstudio/build-tasks-dockerfiles/ repo to konflux, so now all the pipelines in that repo have to run in the rhtap-build-tenant namespace. And we want to run e2e tests in that repo as a Tekton pipeline, not via Prow (why?).

We wanted to use a konflux integration test for running the e2e-tests after source-build image is built, use similar approach like the build-definitions CI but it will be a integration-pipeline instead of build-pipeline so the rhtap-build-tenant:appstudio-pipeline needs the same level of privileges that our tekton-ci:appstudio-pipeline sa has, to be able to run the e2e-tests. Prow was not picked because we are migrating away from it and will be moving to all the konflux-ci in future. Does it makes sense?

Copy link
Member

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Ack, thanks for the explanation 👍

Copy link

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmeliik, tisutisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit aec5505 into redhat-appstudio:main May 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants