Switch from 'embedding' to 'starting' IPython #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kemitche
force-pushed
the
no-embed-ipython
branch
from
4f2efd2
to
7984dd0
Compare
spladug
suggested changes
Oct 28, 2020
| from IPython.terminal.embed import InteractiveShellEmbed | ||
| from IPython.core.interactiveshell import DummyMod | ||
|
|
||
| shell = InteractiveShellEmbed(banner2=banner) |
There was a problem hiding this comment.
It looks like the banner isn't getting shown.
There was a problem hiding this comment.
ubuntu@reddit:~/src/harold2 (harold2)$ onevm shell
Running “baseplate-shell /home/ubuntu/src/harold2/example.ini”…
INFO:raven.base.Client:Raven is not configured (logging is disabled). Please see the documentation for more information.
Python 3.8.5 (default, Jul 20 2020, 19:48:14)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.18.1 -- An enhanced Interactive Python. Type '?' for help.
In [1]: context
Out[1]: <baseplate.RequestContext at 0x7fdd587c3610>
so the values are there as expected but there's no message explaining how to use 'em.
There was a problem hiding this comment.
Good catch, let me get the banner back into place! (I'm so used to it at this point I've gloss right over it)
Embedding IPython results in issues where import statements and other
globals changes in the shell environment don't work as expected.[1]
As an example, the following commands result in a NameError:
In [1]: import time
In [2]: def foo():
...: print(time.time())
...:
In [3]: foo()
---------------------------------------------------------------------------
NameError Traceback (most recent call last)
<ipython-input-3-c19b6d9633cf> in <module>
----> 1 foo()
<ipython-input-2-a038e7f91c93> in foo()
1 def foo():
----> 2 print(time.time())
3
NameError: name 'time' is not defined
By switching to use "start_ipython()" instead, we get an environment
more similar to what we get by running `ipython` directly.
[1] ipython/ipython#62
kemitche
force-pushed
the
no-embed-ipython
branch
from
7984dd0
to
85c5c05
Compare
kemitche
force-pushed
the
no-embed-ipython
branch
from
47314a7
to
df4f7d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedding IPython results in issues where import statements and other
globals changes in the shell environment don't work as expected.[1]
As an example, the following commands result in a NameError:
By switching to use "start_ipython()" instead, we get an environment
more similar to what we get by running
ipythondirectly.[1] ipython/ipython#62