T1037.005, T1543.001, T1543.004 Persist Tests Enhancements #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2024 10:17
T1037.005, T1543.001, T1543.004
svc-github-aws-opensource
force-pushed
the
master
branch
2 times, most recently
from
a8da3ed
to
58496ee
Compare
cyberbuff
requested changes
May 16, 2024
Comment on lines
+37
to
+42
| - name: Launch Daemon - Users Directory | ||
| auto_generated_guid: | ||
| description: | | ||
| Utilize LaunchDaemon in /Users directory to touch temporary file in /tmp | ||
| supported_platforms: | ||
| - macos |
There was a problem hiding this comment.
My suggestion here would be instead of creating a new test, we can create a new input argument in the previous test launch_daemons_path and have a default value of /Library/LaunchDaemons. If needed, others can change this path to execute in a different directory(say Users directory). What are your thoughts ?
Comment on lines
+66
to
+67
| cleanup_command: | | ||
| sudo launchctl unload tmp/T1037_005_daemon.plist |
There was a problem hiding this comment.
launchctl load command is not called in the executor-command. Is this by mistake ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
MACOS ONLY
StartupParameters.plist, two bash scripts, and two plist files (one for agent, one for daemon) to be spawned from the bash scripts./Library/LaunchAgentsin addition to the already existing~/Library/LaunchAgentstest~/Library/LaunchDaemonsin addition to the already existing/Library/LaunchDaemonstestTesting:
Tested on Apple M1 Pro Sonoma 14.3.1
Associated Issues: