sample weights #16
Open
sample weights #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhujiem
force-pushed
the
main
branch
2 times, most recently
from
29f1d24
to
abd5182
Compare
zhujiem
force-pushed
the
main
branch
11 times, most recently
from
877bb61
to
21b9fe2
Compare
xpai
force-pushed
the
main
branch
6 times, most recently
from
230d551
to
19e0665
Compare
xpai
force-pushed
the
main
branch
4 times, most recently
from
1a52985
to
0fd6262
Compare
xpai
force-pushed
the
main
branch
2 times, most recently
from
d7bb3d6
to
d2bd50a
Compare
xpai
force-pushed
the
main
branch
3 times, most recently
from
e67c20d
to
8caae0a
Compare
xpai
force-pushed
the
main
branch
2 times, most recently
from
43a2ace
to
df04ae1
Compare
xpai
force-pushed
the
main
branch
4 times, most recently
from
0322fe5
to
42fa7a6
Compare
xpai
force-pushed
the
main
branch
12 times, most recently
from
65d7d08
to
e98de98
Compare
xpai
force-pushed
the
main
branch
5 times, most recently
from
d4e8a8d
to
7028d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to add sample weights to model instances, by specifying
weight_colto the dataset config. This creates a sample_weight: 1 in the feature mapjson. When this is absent, from now on all instances receive a weight 1 by default, since pytorch enforces DataLoader to output tensor so we cannot set the weights toNone. We also set the package dependency totorch=1.7the last version that supportsfftas used now by theHolographicInteractionLayer.