-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: divide crashlogs in two different forms for tvs and other devices #782
base: master
Are you sure you want to change the base?
Conversation
left the old form url for some reasons: many crashes from different forks come there. many crashes are already fixed but still recieved because people are using old versions. rename old folder as legacy crashes. so pls make 2 new forms and different folder and tell me here or private and i shall push a commit including the new urls. |
} else { | ||
"FORM_URL_FOR_PHONES" | ||
} | ||
|
||
val data = mapOf( | ||
"entry.1993829403" to errorContent.toJSON() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you checked that this key does not differ between forms?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you checked that this key does not differ between forms?
hmm, found out that it won't be an issue because the form and its input data structure is same its just we have seperated their endpoint reciever url
The crash report system has to be reworked entirely as google forms is a duck tape solution. If you poke at this I would suggest that you instead implement it as a real crash reporting system |
how and by reworking what??please tell steps of what needs to be ditched and cleaned up etc. |
Instead of reporting to google forms (that just wont load after ~500k crash reports, and is super slow) we should instead use a real crash reporting site. I think saikou uses a more sophisticated crash reporting site, if you want to take a look at that. |
saikou and its popular fork Dantotsu uses google firebase analytics & crashlytics 👽 |
No description provided.