feat(ui): new dialog on adding repository and auto redirection #1025
Conversation
# Conflicts: # app/src/main/res/values/strings.xml
|
Explain why this should be added and what it does. I can read the code, but I dont understand the intent behind it. |
Out of all extensions for every repository only few work, but people press download button and add all of them , even disabled ones, that contributes to huge amount of bloat as well as waste of time, for example an Indian presses download button when adding hexated repo, instead of only 2 hindi extesnions he downloads whole bunch of indonesian, phillipino and s*x extensions that are of no use to her, not only uninstalling them is a waste of time, but produces bloat in extension sheet, in new way we show a reposiotry download succesfully dialog and redirect to that particular repo to download her desired extensions, and ask them that we dont take any responsibility of 3rd party extensions, because nowadays people are using some 3rd party sites that we are not affiliated with, and thus they will download only those with their flags and languages. this is a win win fr, big fan bhai big fan ❤️🔥 |
|
For the record I quite like this PR as I accidentally press download all sometimes myself then spend time removing extensions so I do think this is a good idea personally. |
|
I dont see any obvious bugs from reading the code, so if I dont find anything in testing this will be merged. |
|
This will be merged after further testing. |
# Conflicts: # app/src/main/java/com/lagradost/cloudstream3/MainActivity.kt
| setTitle(repositoryName) | ||
| setMessage(R.string.download_all_plugins_from_repo) | ||
| // won't show "open button" when adding from settings | ||
| if (!isExtensionsFragment) { |
There was a problem hiding this comment.
if user is adding a repo manually with add repo button, he doesnt need the go to repo button, because the added repo is visible anyways after dismissal
There was a problem hiding this comment.
Nah, removing that option just makes it a waste of a popup then
There was a problem hiding this comment.
what to do then, remove popup here or add button ? without popup we can show a toast of added successfuly, non intrusive also
No description provided.