Fix for wrongly simplified neighbour contours #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two fixes for walkContour/simplifyContour: - Fix for floating error innacuracy when calculating the maximum deviation during simplifyContour: ensure points are passed to distancePtSeg on the same order for both neighbour contours. - Fix for regions touching only in one vertex: during walkContour mark vertices that touch another region in only one vertex, and then let simplifyContour insert that vertex in the initial polygon. See the post "Two bugs in contour generation (and fixes)" in Recast forum for a detailed description https://groups.google.com/forum/#!topic/recastnavigation/OHK5JWLvWs0
|
It seems the changes assume dtTempContour::verts are unsigned shorts, rather than unsigned chars. Mistake, or am I missing something? |
|
Is there a chance this could be ported into the version of walkContour and simplifyContour that's being called from rcBuildContours? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes for walkContour/simplifyContour:
deviation during simplifyContour: ensure points are passed to
distancePtSeg on the same order for both neighbour contours.
vertices that touch another region in only one vertex, and then let
simplifyContour insert that vertex in the initial polygon.
See the post "Two bugs in contour generation (and fixes)" in Recast
forum for a detailed description
https://groups.google.com/forum/#!topic/recastnavigation/OHK5JWLvWs0