Don't discard changes that occur after hitting MAX_UPDATE #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobbotsch
reviewed
Mar 19, 2018
| abortedEarly = true; | ||
|
|
||
| if (!contains(m_update, m_nupdate, ob->touched[j])) | ||
| m_update[m_nupdate++] = ob->touched[j]; |
There was a problem hiding this comment.
This can overflow m_update now.
jakobbotsch
reviewed
Mar 19, 2018
| abortedEarly = true; | ||
|
|
||
| if (!contains(m_update, m_nupdate, ob->touched[j])) | ||
| m_update[m_nupdate++] = ob->touched[j]; |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if we hit the maximum number of requested changes, the rest of the changes are discarded. This pr changes it so that we always complete an obstacle once we start working on it, and the remaining obstacles are then moved to the front of the line to be processed next update.