Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change find backup procedure for Veeam V12.1 and later #3214

Merged
merged 2 commits into from May 3, 2024

Conversation

idna38
Copy link
Contributor

@idna38 idna38 commented Apr 30, 2024

Relax-and-Recover (ReaR) Pull Request Template

Please fill in the following items before submitting a new pull request:

Pull Request Details:
  • Type: Enhancement

  • Impact: Normal

  • How was this pull request tested?
    On every Veeam supported Linux distribution
    RHEL 9.x
    RHEL 8.x
    Debian 10.13
    Debian 11.9
    Debian 12.5
    Ubuntu 18.04
    Ubuntu 20.04
    Ubuntu 22.04
    SLES 12 SP5
    SLES 15 SP5

  • Description of the changes in this pull request:
    changed list backup option, to enable recovery do a different system

This changes have no impact on older version
Copy link
Member

@schlomo schlomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, please use HOSTNAME.

Maybe just a needless worry: What happens if you have thousands of systems covered by Veeam? How long will this run? Will there be paginated output where you have to press ENTER to continue? Or maybe the output will be limited to the first XX entries?

Is there a way to tell the backup list command to filter for the desired hostname instead of doing the filter after the fact?

Finally, the string $HOSTNAME could accidentally also appear in other fields as the hostname itself, so that I would like to suggest narrowing down the search to avoid potential false positive matches.

usr/share/rear/restore/VEEAM/default/450_find_backup.sh Outdated Show resolved Hide resolved
Copy link
Member

@schlomo schlomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing more context and testing the improved solution.

(@idna38 and I had a pairworking session on this)

@schlomo schlomo merged commit 6389691 into rear:master May 3, 2024
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants