Gulp watch fixes #1816
Gulp watch fixes #1816
Conversation
jessecstewart
commented
Oct 27, 2016
•
jessecstewart
commented
- Watch fixes
- Different colors for various watches (jade, styles, scripts)
- runDev uses yarn
|
@realtymaps/github-review |
| @@ -1,6 +1,7 @@ | |||
| require '../../common/extensions/strings' | |||
| paths = require '../../common/config/paths' | |||
| gulp = require 'gulp' | |||
| watch = require 'gulp-watch' | |||
There was a problem hiding this comment.
Switch from gulp4 watch to this, which uses chokidar. I think this is what gulp4 was using previously and it worked better.
| @@ -12,6 +13,8 @@ markup = (app) -> | |||
| markupFn = () -> | |||
| _testCb() if _testCb | |||
|
|
|||
| gutil.log "Building markup:", gutil.colors.bgYellow(paths[app].jade) | |||
There was a problem hiding this comment.
Added some different colors for jade, styles, and scripts so it is easier to see what's building
| @@ -22,7 +22,7 @@ browserifyTask = ({app, watch, prod, doSourceMaps}) -> | |||
| '!' + paths.frontendCommon.root + 'scripts/**/*prod.' + ext | |||
| paths[app].root + 'scripts/**/*.' + ext | |||
| '!' + paths[app].root + 'scripts/**/*prod.' + ext | |||
| paths.tmp + '*.js' | |||
| paths.temp + '*.js' | |||
There was a problem hiding this comment.
Fixed typo, but it didn't really seem to be breaking anything. I guess because browserify was getting it through a require anyway.
| logger.debug -> inputGlob | ||
| logger.debug -> "@@@@@@@@@@@@@@@@@@@" | ||
| # logger.debug -> "@@@@ inputGlob @@@@" | ||
| # logger.debug -> inputGlob |
There was a problem hiding this comment.
I actually like seeing the glob so can we just make this another log level?
|
Circle says your missing the lock file. However I do not see where you deleted it. |
|
Already started re-running on CI |
| @@ -12,6 +13,8 @@ markup = (app) -> | |||
| markupFn = () -> | |||
| _testCb() if _testCb | |||
|
|
|||
| gutil.log "Building markup:", gutil.colors.bgYellow(paths[app].jade) | |||
| fi | ||
|
|
||
| if [[ "$DO_INSTALL" == "true" ]] | ||
| then | ||
| foreman run npm install |
There was a problem hiding this comment.
just noticed the ./scripts/app/clean needs to be fixed as well. I think yarn cache clean will possibly work.
There was a problem hiding this comment.
Also reshrinkwrap is missing some things as well.
# make sure nothing extraneous exists
npm prune
# make sure everything else is up-to-date
npm install "$OPTIONS"
to
# make sure nothing extraneous exists
#???? see https://github.com/yarnpkg/yarn/issues/696
yarn install
# make sure everything else is up-to-date
yarn install "$OPTIONS"
|
@nmccready I'm at a loss on this lockfile issue. I tried adding a done() to the test but now it says "timeout of 10000ms exceeded" |
|
Wow it passed. I updated the lockfile, but I'm not sure why that would have been necessary |
