RCOCOA-2289: Update Base url API #8560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianaafanador3
force-pushed
the
dp/base_url
branch
from
df134d5
to
1a6287d
Compare
nirinchev
approved these changes
Apr 30, 2024
dianaafanador3
force-pushed
the
dp/base_url
branch
2 times, most recently
from
2ba4a8e
to
0c47eb4
Compare
clementetb
reviewed
Apr 30, 2024
dianaafanador3
force-pushed
the
dp/base_url
branch
4 times, most recently
from
29509bc
to
0ac8db6
Compare
dianaafanador3
force-pushed
the
dp/base_url
branch
from
0ac8db6
to
8985c05
Compare
nirinchev
reviewed
May 1, 2024
|
Solved PR comments and changed the approach for the Swift API, we are now using |
tgoyne
reviewed
May 1, 2024
nirinchev
approved these changes
May 1, 2024
tgoyne
reviewed
May 1, 2024
tgoyne
approved these changes
May 1, 2024
|
These failures seem to be all 502s, so I'll go ahead and merge this 😩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for updating Atlas Device Sync's base url, in case the need to roam between servers (cloud and/or edge server). (#8486)
Notes: This is gonna be tested manually, for now there is just one simple test which just check the new url is set.