Update for the app services split branch #8539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
added
no-changelog
no-jira-ticket
tgoyne
force-pushed
the
tg/app-services-split
branch
from
bab3dfd
to
04d58ce
Compare
tgoyne
force-pushed
the
tg/app-services-split
branch
2 times, most recently
from
1f375ce
to
2ea8d98
Compare
tgoyne
force-pushed
the
tg/app-services-split
branch
from
2ea8d98
to
6520318
Compare
nirinchev
approved these changes
Apr 29, 2024
| @@ -334,16 +330,16 @@ - (instancetype)initWithApp:(std::shared_ptr<realm::app::App>&&)app config:(RLMA | |||
| - (instancetype)initWithConfiguration:(RLMAppConfiguration *)configuration { | |||
| if (self = [super init]) { | |||
| _app = RLMTranslateError([&] { | |||
| return app::App::get_app(app::App::CacheMode::Enabled, configuration.config, configuration.clientConfig); | |||
| return app::App::get_app(app::App::CacheMode::Disabled, configuration.config); | |||
There was a problem hiding this comment.
Why are we disabling the caching here? Is it because we're anyway maintaining an SDK-level cache?
There was a problem hiding this comment.
Yeah, we never actually get a cache hit in the core cache unless something has gone wrong.
| @see `RLMSyncErrorClientResetError`, `RLMSyncErrorPermissionDeniedError` | ||
|
|
||
| @see ```RLMSyncErrorClientResetError``, ``RLMSyncErrorPermissionDeniedError`` |
There was a problem hiding this comment.
Looks like we have an extra backtick here
Suggested change
| @see ```RLMSyncErrorClientResetError``, ``RLMSyncErrorPermissionDeniedError`` | |
| @see ``RLMSyncErrorClientResetError``, ``RLMSyncErrorPermissionDeniedError`` |
dianaafanador3
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
realm/realm-core#7300