-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCOCOA-2308: Add GHA workflow for core prebuilds #8517
Merged
Merged
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
51db15e
Try and run the actual builds
nirinchev edfde19
Escape commands
nirinchev bbbbb0f
Disable some builds temporarily
nirinchev c3b6ab4
Use correct working directory
nirinchev cd65a1a
Use a fancier expression, checkout recursive submodules
nirinchev a38acf6
add job to merge the xcframeworks
nirinchev 4ffd28d
Tweaks
nirinchev 05e13bc
Build all platforms
nirinchev eb1f288
Fix platform names for tvos
nirinchev ad9ea13
Move some files around
nirinchev 7eb0fea
Allow specifying version in the workflow dispatch inputs
nirinchev 5167648
Fix shell script
nirinchev cc6db16
Remove trailing slash
nirinchev 7514575
Revert SDK version
nirinchev 723f7cc
Try to checkout everything
nirinchev ac64be7
Revert package.swift changes
nirinchev 42ab8f6
Clarify input arg
nirinchev 7fba374
Merge branch 'master' into ni/prebuilds-2
nirinchev File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
VERSION=10.48.0 | ||
REALM_CORE_VERSION=13.26.0 | ||
REALM_CORE_VERSION=v13.26.0 | ||
nirinchev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
STITCH_VERSION=8bf8ebcff6e804586c30a6ccbadb060753071a42 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need core's submodules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are needed to build the core binaries, aren't they? Otherwise, I get errors like this one when running
build-apple-device.sh
: