Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: use addons search #11303

Merged
merged 1 commit into from Apr 25, 2024
Merged

Docs: use addons search #11303

merged 1 commit into from Apr 25, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 24, 2024

Do not install readthedocs-sphinx-search extension and hook the "Search docs" input from the top right to the readthedocs-search-show event to trigger the addons search modal 馃帀

Peek 2024-04-24 13-52


馃摎 Documentation previews 馃摎

Do not install `readthedocs-sphinx-search` extension and hook the "Search docs"
input from the top right to the `readthedocs-search-show` event to trigger the
addons search modal.
@humitos humitos requested a review from a team as a code owner April 24, 2024 11:50
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a change to the JS file here, is that missing in the commit?

@humitos
Copy link
Member Author

humitos commented Apr 25, 2024

The JS change is done in the Sphinx theme itself: https://github.com/readthedocs/sphinx_rtd_theme/pull/1526/files/ecebe4cefe16f26ef205d32f72b1938d2c45dd3b..c8056050ad64733413026364b617d153d71989c1

@humitos humitos merged commit dea3487 into main Apr 25, 2024
8 checks passed
@humitos humitos deleted the humitos/use-addons-search branch April 25, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants