Skip to content

Commit

Permalink
Upgrade Celery and friends to latest versions
Browse files Browse the repository at this point in the history
We are receiving "Acquire on closed pool" error randomly after running instances
for more than ~1 day and calling `self.app.control.cancel_consumer` from our
task that kills VM instances.

This seems to be a known problem in 3.x Celery verions but some users reported
that it's still present in <4.4.

- celery/celery#4410 (comment)
- https://stackoverflow.com/questions/36789805/celery-kombu-fails-after-self-connections-acquire
- celery/celery#1839

Celery released 5.x on September, so I'm upgrading to it directly as a test. If
everything keep working together, we can leave it. Otherwise, we can go back to
latest 4.4.x series: 4.4.7.
  • Loading branch information
humitos committed Dec 28, 2020
1 parent d33188a commit 4beda0e
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions requirements/pip.txt
Expand Up @@ -31,15 +31,9 @@ pyyaml==5.3.1
Pygments==2.7.3

# Basic tools
# Redis 3.x has an incompatible change and fails
# https://stackoverflow.com/questions/53331405/django-compress-error-invalid-input-of-type-cachekey
# https://github.com/sebleier/django-redis-cache/pull/162
redis==2.10.6 # pyup: ignore
# Kombu >4.3 requires redis>=3.2
kombu==4.3.0 # pyup: ignore
# Celery 4.2 is incompatible with our code
# when ALWAYS_EAGER = True
celery==4.1.1 # pyup: ignore
redis==3.5.3
kombu==5.0.2
celery==5.0.2

# When upgrading to 0.43.0 we should double check the ``base.html`` change
# described in the changelog. In previous versions, the allauth app included a
Expand Down

0 comments on commit 4beda0e

Please sign in to comment.