Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update Fade.d.ts to change onLeave prop to the correct onExit #2776

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: update Fade.d.ts to change onLeave prop to the correct onExit #2776

wants to merge 1 commit into from

Commits on Nov 2, 2023

  1. Update Fade.d.ts to fix incorrect onLeave typing 

    ## Motivation

When testing, we realized that our `onLeave` callback wasn't being called at all for the `Fade` component.

Looking at the types in react-transition-group, it looks like the actual correct prop is `onExit`.

## Fix

Update typings to `onExit`
    @hsource
    hsource committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    63fea08 View commit details
    Browse the repository at this point in the history