Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Jumbotron): Remove Jumbotron component #2118

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
51 changes: 0 additions & 51 deletions docs/lib/Components/JumbotronPage.js

This file was deleted.

4 changes: 0 additions & 4 deletions docs/lib/Components/index.js
Expand Up @@ -54,10 +54,6 @@ const items = [
name: 'Input Group',
to: '/components/input-group/'
},
{
name: 'Jumbotron',
to: '/components/jumbotron/'
},
{
name: 'Layout',
to: '/components/layout/'
Expand Down
6 changes: 3 additions & 3 deletions docs/lib/Home/index.js
@@ -1,6 +1,6 @@
import React from 'react';
import { PrismCode } from 'react-prism';
import { Button, Container, Row, Col, Jumbotron } from 'reactstrap';
import { Button, Container, Row, Col } from 'reactstrap';
import { Link } from 'react-router';
import Example from '../examples/import-basic';

Expand All @@ -9,7 +9,7 @@ const importBasic = require('!!raw-loader!../examples/import-basic');
export default () => {
return (
<div>
<Jumbotron tag="section" className="jumbotron-header text-center mb-3">
<section className="jumbotron-header rounded px-3 px-sm-4 py-3 py-sm-5 text-center mb-3">
<Container>
<Row>
<Col>
Expand Down Expand Up @@ -40,7 +40,7 @@ export default () => {
</Col>
</Row>
</Container>
</Jumbotron>
</section>
<Container>
<Row className="justify-content-sm-center">
<Col sm={8} className="docSearch-content">
Expand Down
2 changes: 1 addition & 1 deletion docs/lib/NotFound/index.js
Expand Up @@ -7,7 +7,7 @@ export default () => {
return (
<div>
<Helmet title="404 Page Not Found" />
<section className="jumbotron text-center mb-3">
<section className="rounded px-3 px-sm-4 py-3 py-sm-5 text-center mb-3">
<Container>
<Row>
<Col>
Expand Down
5 changes: 2 additions & 3 deletions docs/lib/PremiumThemes/index.js
Expand Up @@ -7,14 +7,13 @@ import {
Container,
Row,
Col,
Jumbotron,
} from 'reactstrap';
import premiumThemes from './premium';

export default () => {
return (
<div>
<Jumbotron tag="section" className="jumbotron-header text-center mb-3">
<section className="jumbotron-header rounded px-3 px-sm-4 py-3 py-sm-5 text-center mb-3">
<p className="lead">
<img src="/assets/logo.png" alt="" width="110px" />
</p>
Expand All @@ -23,7 +22,7 @@ export default () => {
A collection of free and premium React templates and themes powered by
Reactstrap
</h4>
</Jumbotron>
</section>
{premiumThemes.map(company => (
<Container key={company.creator.name} className="premium-section">
<h2 className="font-weight-bold">{company.creator.name}</h2>
Expand Down
20 changes: 0 additions & 20 deletions docs/lib/examples/Jumbotron.js

This file was deleted.

17 changes: 0 additions & 17 deletions docs/lib/examples/JumbotronFluid.js

This file was deleted.

2 changes: 0 additions & 2 deletions docs/lib/routes.js
Expand Up @@ -23,7 +23,6 @@ import CardPage from './Components/CardPage';
import TablesPage from './Components/TablesPage';
import PaginationPage from './Components/PaginationPage';
import TabsPage from './Components/TabsPage';
import JumbotronPage from './Components/JumbotronPage';
import AlertsPage from './Components/AlertsPage';
import ToastsPage from './Components/ToastsPage';
import CollapsePage from './Components/CollapsePage';
Expand Down Expand Up @@ -66,7 +65,6 @@ const routes = (
<Route path="tabs/" component={TabsPage} />
<Route path="alerts/" component={AlertsPage} />
<Route path="toasts/" component={ToastsPage} />
<Route path="jumbotron/" component={JumbotronPage} />
<Route path="collapse/" component={CollapsePage} />
<Route path="carousel/" component={CarouselPage} />
<Route path="list/" component={ListPage} />
Expand Down
40 changes: 0 additions & 40 deletions src/Jumbotron.js

This file was deleted.

37 changes: 0 additions & 37 deletions src/__tests__/Jumbotron.spec.js

This file was deleted.

1 change: 0 additions & 1 deletion src/index.js
Expand Up @@ -73,7 +73,6 @@ export PaginationItem from './PaginationItem';
export PaginationLink from './PaginationLink';
export TabContent from './TabContent';
export TabPane from './TabPane';
export Jumbotron from './Jumbotron';
export Alert from './Alert';
export Toast from './Toast';
export ToastBody from './ToastBody';
Expand Down
2 changes: 0 additions & 2 deletions types/index.d.ts
Expand Up @@ -88,8 +88,6 @@ export { default as InputGroupButtonDropdown } from './lib/InputGroupButtonDropd
export { InputGroupButtonDropdownProps } from './lib/InputGroupButtonDropdown';
export { default as InputGroupText } from './lib/InputGroupText';
export { InputGroupTextProps } from './lib/InputGroupText';
export { default as Jumbotron } from './lib/Jumbotron';
export { JumbotronProps } from './lib/Jumbotron';
export { default as Label } from './lib/Label';
export { LabelProps } from './lib/Label';
export { default as ListGroup } from './lib/ListGroup';
Expand Down
12 changes: 0 additions & 12 deletions types/lib/Jumbotron.d.ts

This file was deleted.

2 changes: 0 additions & 2 deletions types/lib/index.d.ts
Expand Up @@ -92,8 +92,6 @@ export { default as InputGroupButtonDropdown } from './InputGroupButtonDropdown'
export { InputGroupButtonDropdownProps } from './InputGroupButtonDropdown';
export { default as InputGroupText } from './InputGroupText';
export { InputGroupTextProps } from './InputGroupText';
export { default as Jumbotron } from './Jumbotron';
export { JumbotronProps } from './Jumbotron';
export { default as Label } from './Label';
export { LabelProps } from './Label';
export { default as ListGroup } from './ListGroup';
Expand Down
42 changes: 0 additions & 42 deletions types/reactstrap-tests.tsx
Expand Up @@ -59,7 +59,6 @@ import {
Modal,
ModalBody,
ModalHeader,
Jumbotron,
Media,
Nav,
Navbar,
Expand Down Expand Up @@ -2083,44 +2082,6 @@ const Example58 = (props: any) => {
);
};

const Example59 = (props: any) => {
return (
<div>
<Jumbotron>
<h1 className="display-3">Hello, world!</h1>
<p className="lead">
This is a simple hero unit, a simple Jumbotron-style component for
calling extra attention to featured content or information.
</p>
<hr className="my-2" />
<p>
It uses utility classes for typgraphy and spacing to space content out
within the larger container.
</p>
<p className="lead">
<Button color="primary">Learn More</Button>
</p>
</Jumbotron>
</div>
);
};

const Example60 = (props: any) => {
return (
<div>
<Jumbotron fluid>
<Container fluid>
<h1 className="display-3">Fluid jumbotron</h1>
<p className="lead">
This is a modified jumbotron that occupies the entire horizontal
space of its parent.
</p>
</Container>
</Jumbotron>
</div>
);
};

class Example61 extends React.Component {
render() {
return (
Expand Down Expand Up @@ -4888,7 +4849,6 @@ import { default as InputGroup_ } from './lib/InputGroup'; /* tslint:disable-lin
import { default as InputGroupAddon_ } from './lib/InputGroupAddon'; /* tslint:disable-line: no-relative-import-in-test */
import { default as InputGroupButtonDropdown_ } from './lib/InputGroupButtonDropdown'; /* tslint:disable-line: no-relative-import-in-test */
import { default as InputGroupText_ } from './lib/InputGroupText'; /* tslint:disable-line: no-relative-import-in-test */
import { default as Jumbotron_ } from './lib/Jumbotron'; /* tslint:disable-line: no-relative-import-in-test */
import { default as Label_ } from './lib/Label'; /* tslint:disable-line: no-relative-import-in-test */
import { default as ListGroup_ } from './lib/ListGroup'; /* tslint:disable-line: no-relative-import-in-test */
import { default as ListGroupItem_ } from './lib/ListGroupItem'; /* tslint:disable-line: no-relative-import-in-test */
Expand Down Expand Up @@ -5001,7 +4961,6 @@ function AnyPropExample() {
addonType="prepend"
/>
<InputGroupText_ foo={1} bar={false} foobar="example" />
<Jumbotron_ foo={1} bar={false} foobar="example" />
<Label_ foo={1} bar={false} foobar="example" />
<ListGroup_ foo={1} bar={false} foobar="example" />
<ListGroupItem_ foo={1} bar={false} foobar="example" />
Expand Down Expand Up @@ -5755,7 +5714,6 @@ const MegaTest = () => {
addonType="append"
/>
<InputGroupText ref={React.createRef<InputGroupText>()} {...htmlProps} />
<Jumbotron ref={React.createRef<Jumbotron>()} {...htmlProps} />
<Label ref={React.createRef<Label>()} {...htmlProps} />
<ListGroup ref={React.createRef<ListGroup>()} {...htmlProps} />
<ListGroupItem ref={React.createRef<ListGroupItem>()} {...htmlProps} />
Expand Down