Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Implementing dynamic css classes in React components #248

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vijaypushkin
Copy link

@vijaypushkin vijaypushkin commented Apr 18, 2023

The proposed feature is to add a new syntax for dynamically adding classes to React components. This syntax would be similar to the ngClass directive in Angular, allowing developers to use a classNames attribute to add or remove classes based on certain conditions.

View RFC

View PR

@facebook-github-bot
Copy link
Collaborator

Hi @vijaypushkin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@OlegLustenko
Copy link

Facebook doesn't use classes heavily in internals.

And this could be implemented in the user land.

More likely it will never be adopted.

However I like your spirit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants