Skip to content

Commit

Permalink
Housekeeping Update Build to use dotnet build (#3799)
Browse files Browse the repository at this point in the history
<!-- Please be sure to read the
[Contribute](https://github.com/reactiveui/reactiveui#contribute)
section of the README -->

**What kind of change does this PR introduce?**
<!-- Bug fix, feature, docs update, ... -->

Update build script

**What is the current behavior?**
<!-- You can also link to an open issue here. -->

using MsBuild

**What is the new behavior?**
<!-- If this is a feature change -->

using DotNet Build

**What might this PR break?**

none expected

**Please check if the PR fulfills these requirements**
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

**Other information**:
  • Loading branch information
ChrisPulman committed Apr 30, 2024
1 parent 8e33bf4 commit a31490e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/ci-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
with:
configuration: Release
productNamespacePrefix: "ReactiveUI"
dotNetBuild: true
useVisualStudioPreview: false
useMauiCheckDotNetTool: false
solutionFile: "reactiveui.sln"
1 change: 1 addition & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
with:
configuration: Release
productNamespacePrefix: "ReactiveUI"
dotNetBuild: true
useVisualStudioPreview: true
useMauiCheckDotNetTool: false
solutionFile: "reactiveui.sln"
Expand Down
1 change: 1 addition & 0 deletions src/ReactiveUI.WinUI/ReactiveUI.WinUI.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<NoWarn>$(NoWarn);NETSDK1206</NoWarn>
<DefineConstants>IS_WINUI;WINUI_TARGET;</DefineConstants>
<RuntimeIdentifiers>win-x64;win-x86;win-arm64</RuntimeIdentifiers>
<EnableMsixTooling>true</EnableMsixTooling>
<SupportedOSPlatformVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'windows'">10.0.19041.0</SupportedOSPlatformVersion>
<TargetPlatformMinVersion Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'windows'">10.0.19041.0</TargetPlatformMinVersion>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "8.0.204",
"version": "8.0.10",
"rollForward": "latestMinor"
},
"msbuild-sdks": {
Expand Down

0 comments on commit a31490e

Please sign in to comment.