Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes: #10

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

changes: #10

wants to merge 6 commits into from

Conversation

alirezavalizade
Copy link

@alirezavalizade alirezavalizade commented Mar 9, 2018 •
edited

  • add type checking for props
  • add componentWillMount(){} lifecycle (maybe it's needed in SSR for api calling or something - we should have this)
  • code cleaning

@Pajn
Copy link

Pajn commented Mar 10, 2018

componentWillMount is on the path on deprecation https://medium.com/@baphemot/whats-new-in-react-16-3-d2c9b7b6193b

I'm not ruling anything but that might be worth considering before writing new code for it.

@Pajn Pajn mentioned this pull request Mar 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alirezavalizade @Pajn