New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small components refactoring, add propTypes, update tests #82
Open
isnifer
wants to merge
9
commits into
reactide:master
Choose a base branch
from
isnifer:feature/refactor-small-components
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Small components refactoring, add propTypes, update tests #82
isnifer
wants to merge
9
commits into
reactide:master
from
isnifer:feature/refactor-small-components
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istent Make tests code more consistent
added travis, more tests added
This branch was rebased over updated |
@isnifer what do you think about replace babel-preset-es2015 to babel-preset-env |
@kulakowka good idea, we should only target current version of Chrome bundled in electron |
itsmepetrov
approved these changes
Apr 4, 2017
Hey, @JiniHendrix, @markmarcelo, @bitadj, please take a look! |
bitadj
force-pushed
the
master
branch
12 times, most recently
from
April 5, 2018 12:48
e69645b
to
0cc2e45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, @JiniHendrix, @markmarcelo, @bitadj, please take a look!