Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OS Build options to readme #176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

translucentfocus
Copy link

@translucentfocus translucentfocus commented Sep 21, 2019

By default, the readme will build a MacOS binary. Added instructions for MacOS, Linux & Windows for clarity

Noticed the readme doesn't include that you may need to change your package.json depending on your OS
Copy link
Collaborator

@EP36 EP36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Appreciate it!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform=windows
should be: platform=win32

@translucentfocus
Copy link
Author

Following up as this has been stuck for ~6 months now with only 1 approver 😢

Would like to either close the request or get it completed 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants